Temporarily disable broken Webpack JS test suites#35955
Merged
kdmccormick merged 2 commits intoopenedx:masterfrom Dec 4, 2024
Merged
Temporarily disable broken Webpack JS test suites#35955kdmccormick merged 2 commits intoopenedx:masterfrom
kdmccormick merged 2 commits intoopenedx:masterfrom
Conversation
Adds a "DieHardPlugin" to the Webpack build. See enclosed code comment for more details.
Should be re-enabled in: openedx#35956
kdmccormick
changed the title
3 tasks
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Contributor
|
2U Release Notice: This PR has been rolled back from the edX production environment. |
1 similar comment
Contributor
|
2U Release Notice: This PR has been rolled back from the edX production environment. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We temporarily disable the three Webpack-based JS test suites. They have been silently broken for a long time. It is not clear yet if only the karma-webpack build config is broken, or if something in the Webpack-built JS itself is broken which is manifesting as the karma-webpack build failing.
The remaining four non-Webpack-based JS test suites are unaffected. These are running as we expect them to.
We add a small "DieHardPlugin" to webpack.common.config.js to ensure that once we re-enable these Webpack JS suites, future breakage to the karma-webpack build will yield a CI failure. I did verify this.
Screenshots
Webpack tests failing silently
(CI screenshot -- notice that it just moves onto
lms javascripteven though the build failed forcms-webpack javascript)Webpack tests failing loudly due to new DieHardPlugin
(local screenshot)
Context
Discovered as part of #35159